Commit 289c964f authored Nov 01, 2022 by Yang Yingliang Committed by Greg Kroah-Hartman Jan 18, 2023

mmc: alcor: fix return value check of mmc_add_host()



[ Upstream commit e93d1468f429475a753d6baa79b853b7ee5ef8c0 ]

mmc_add_host() may return error, if we ignore its return value, the memory
that allocated in mmc_alloc_host() will be leaked and it will lead a kernel
crash because of deleting not added device in the remove path.

So fix this by checking the return value and calling mmc_free_host() in the
error path.

Fixes: c5413ad8 ("mmc: add new Alcor Micro Cardreader SD/MMC driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221101063023.1664968-2-yangyingliang@huawei.com


Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent e8f20523

drivers/mmc/host/alcor.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1114,7 +1114,10 @@ static int alcor_pci_sdmmc_drv_probe(struct platform_device *pdev)
		alcor_hw_init(host);

		dev_set_drvdata(&pdev->dev, host);
		mmc_add_host(mmc);
		ret = mmc_add_host(mmc);
		if (ret)
		goto free_host;

		return 0;

		free_host: