Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8f20523 authored by Trond Myklebust's avatar Trond Myklebust Committed by Greg Kroah-Hartman
Browse files

NFSv4.x: Fail client initialisation if state manager thread can't run 



[ Upstream commit b4e4f66901658fae0614dea5bf91062a5387eda7 ]

If the state manager thread fails to start, then we should just mark the
client initialisation as failed so that other processes or threads don't
get stuck in nfs_wait_client_init_complete().

Reported-by: default avatarChenXiaoSong <chenxiaosong2@huawei.com>
Fixes: 4697bd5e ("NFSv4: Fix a race in the net namespace mount notification")
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent f7a8a1e3

fs/nfs/nfs4state.c

+2 −0
Original line number Diff line number Diff line
@@ -1224,6 +1224,8 @@ void nfs4_schedule_state_manager(struct nfs_client *clp) 
	if (IS_ERR(task)) {

		printk(KERN_ERR "%s: kthread_run: %ld\n",

			__func__, PTR_ERR(task));

		if (!nfs_client_init_is_complete(clp))

			nfs_mark_client_ready(clp, PTR_ERR(task));

		nfs4_clear_state_manager_bit(clp);

		nfs_put_client(clp);

		module_put(THIS_MODULE);