Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 25d851ad authored by Chris Wilson's avatar Chris Wilson
Browse files

drm/i915: Only reschedule the submission tasklet if preemption is possible 



If we couple the scheduler more tightly with the execlists policy, we
can apply the preemption policy to the question of whether we need to
kick the tasklet at all for this priority bump.

v2: Rephrase it as a core i915 policy and not an execlists foible.
v3: Pull the kick together.

Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190507122544.12698-1-chris@chris-wilson.co.uk
parent 39705649

drivers/gpu/drm/i915/gt/intel_engine.h

+0 −18
Original line number Diff line number Diff line
@@ -106,24 +106,6 @@ hangcheck_action_to_str(const enum intel_engine_hangcheck_action a) 


void intel_engines_set_scheduler_caps(struct drm_i915_private *i915);



static inline bool __execlists_need_preempt(int prio, int last)

{

	/*

	 * Allow preemption of low -> normal -> high, but we do

	 * not allow low priority tasks to preempt other low priority

	 * tasks under the impression that latency for low priority

	 * tasks does not matter (as much as background throughput),

	 * so kiss.

	 *

	 * More naturally we would write

	 *	prio >= max(0, last);

	 * except that we wish to prevent triggering preemption at the same

	 * priority level: the task that is running should remain running

	 * to preserve FIFO ordering of dependencies.

	 */

	return prio > max(I915_PRIORITY_NORMAL - 1, last);

}



static inline void

execlists_set_active(struct intel_engine_execlists *execlists,

		     unsigned int bit)

drivers/gpu/drm/i915/gt/intel_lrc.c

+2 −2
Original line number Diff line number Diff line
@@ -252,7 +252,7 @@ static inline bool need_preempt(const struct intel_engine_cs *engine, 
	 * ourselves, ignore the request.

	 */

	last_prio = effective_prio(rq);

	if (!__execlists_need_preempt(engine->execlists.queue_priority_hint,

	if (!i915_scheduler_need_preempt(engine->execlists.queue_priority_hint,

					 last_prio))

		return false;

drivers/gpu/drm/i915/gt/selftest_lrc.c

+6 −1
Original line number Diff line number Diff line
@@ -638,14 +638,19 @@ static struct i915_request *dummy_request(struct intel_engine_cs *engine) 
	GEM_BUG_ON(i915_request_completed(rq));



	i915_sw_fence_init(&rq->submit, dummy_notify);

	i915_sw_fence_commit(&rq->submit);

	set_bit(I915_FENCE_FLAG_ACTIVE, &rq->fence.flags);



	return rq;

}



static void dummy_request_free(struct i915_request *dummy)

{

	/* We have to fake the CS interrupt to kick the next request */

	i915_sw_fence_commit(&dummy->submit);



	i915_request_mark_complete(dummy);

	dma_fence_signal(&dummy->fence);



	i915_sched_node_fini(&dummy->sched);

	i915_sw_fence_fini(&dummy->submit);

drivers/gpu/drm/i915/i915_request.c

+0 −2
Original line number Diff line number Diff line
@@ -1415,9 +1415,7 @@ long i915_request_wait(struct i915_request *rq, 
	if (flags & I915_WAIT_PRIORITY) {

		if (!i915_request_started(rq) && INTEL_GEN(rq->i915) >= 6)

			gen6_rps_boost(rq);

		local_bh_disable(); /* suspend tasklets for reprioritisation */

		i915_schedule_bump_priority(rq, I915_PRIORITY_WAIT);

		local_bh_enable(); /* kick tasklets en masse */

	}



	wait.tsk = current;

drivers/gpu/drm/i915/i915_scheduler.c

+19 −15
Original line number Diff line number Diff line
@@ -261,16 +261,27 @@ sched_lock_engine(const struct i915_sched_node *node, 
	return engine;

}



static bool inflight(const struct i915_request *rq,

		     const struct intel_engine_cs *engine)

static inline int rq_prio(const struct i915_request *rq)

{

	const struct i915_request *active;

	return rq->sched.attr.priority | __NO_PREEMPTION;

}



static void kick_submission(struct intel_engine_cs *engine, int prio)

{

	const struct i915_request *inflight =

		port_request(engine->execlists.port);



	if (!i915_request_is_active(rq))

		return false;

	/*

	 * If we are already the currently executing context, don't

	 * bother evaluating if we should preempt ourselves, or if

	 * we expect nothing to change as a result of running the

	 * tasklet, i.e. we have not change the priority queue

	 * sufficiently to oust the running context.

	 */

	if (inflight && !i915_scheduler_need_preempt(prio, rq_prio(inflight)))

		return;



	active = port_request(engine->execlists.port);

	return active->hw_context == rq->hw_context;

	tasklet_hi_schedule(&engine->execlists.tasklet);

}



static void __i915_schedule(struct i915_request *rq,
@@ -396,15 +407,8 @@ static void __i915_schedule(struct i915_request *rq, 


		engine->execlists.queue_priority_hint = prio;



		/*

		 * If we are already the currently executing context, don't

		 * bother evaluating if we should preempt ourselves.

		 */

		if (inflight(node_to_request(node), engine))

			continue;



		/* Defer (tasklet) submission until after all of our updates. */

		tasklet_hi_schedule(&engine->execlists.tasklet);

		kick_submission(engine, prio);

	}



	spin_unlock(&engine->timeline.lock);