Commit 39705649 authored May 07, 2019 by Chris Wilson

drm/i915: Stop spinning for DROP_IDLE (debugfs/i915_drop_caches)

If the user is racing a call to debugfs/i915_drop_caches with ongoing
submission from another thread/process, we may never end up idling the
GPU and be uninterruptibly spinning in debugfs/i915_drop_caches trying
to catch an idle moment.

Just flush the work once, that should be enough to park the system under
correct conditions. Outside of those we either have a driver bug or the
user is racing themselves. Sadly, because the user may be provoking the
unwanted situation we can't put a warn here to attract attention to a
probable bug.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190507121108.18377-4-chris@chris-wilson.co.uk

parent 1830374e

drivers/gpu/drm/i915/i915_debugfs.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -3947,9 +3947,7 @@ i915_drop_caches_set(void *data, u64 val)
		fs_reclaim_release(GFP_KERNEL);

		if (val & DROP_IDLE) {
		do {
		flush_delayed_work(&i915->gem.retire_work);
		} while (READ_ONCE(i915->gt.awake));
		flush_work(&i915->gem.idle_work);
		}