Commit 25a13e38 authored Jul 23, 2018 by Jia-Ju Bai Committed by Marcel Holtmann Jul 23, 2018

bluetooth: hci_qca: Replace GFP_ATOMIC with GFP_KERNEL



qca_open() and qca_set_baudrate() are never called in atomic context.

They call kzalloc() and bt_skb_alloc() with GFP_ATOMIC,
which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent f6ebfc24

drivers/bluetooth/hci_qca.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -405,7 +405,7 @@ static int qca_open(struct hci_uart *hu)

		BT_DBG("hu %p qca_open", hu);

		qca = kzalloc(sizeof(struct qca_data), GFP_ATOMIC);
		qca = kzalloc(sizeof(struct qca_data), GFP_KERNEL);
		if (!qca)
		return -ENOMEM;

		@@ -891,7 +891,7 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)

		cmd[4] = baudrate;

		skb = bt_skb_alloc(sizeof(cmd), GFP_ATOMIC);
		skb = bt_skb_alloc(sizeof(cmd), GFP_KERNEL);
		if (!skb) {
		bt_dev_err(hdev, "Failed to allocate baudrate packet");
		return -ENOMEM;