Commit f6ebfc24 authored Jul 23, 2018 by Jia-Ju Bai Committed by Marcel Holtmann Jul 23, 2018

bluetooth: hci_intel: Replace GFP_ATOMIC with GFP_KERNEL in inject_cmd_complete()



inject_cmd_complete() is only called by intel_dequeue(),
which is never called in atomic context.

inject_cmd_complete() calls bt_skb_alloc() with GFP_ATOMIC,
which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent cf07e341

drivers/bluetooth/hci_intel.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -458,7 +458,7 @@ static int inject_cmd_complete(struct hci_dev *hdev, __u16 opcode)
		struct hci_event_hdr *hdr;
		struct hci_ev_cmd_complete *evt;

		skb = bt_skb_alloc(sizeof(hdr) + sizeof(evt) + 1, GFP_ATOMIC);
		skb = bt_skb_alloc(sizeof(hdr) + sizeof(evt) + 1, GFP_KERNEL);
		if (!skb)
		return -ENOMEM;