Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 24326039 authored by K. Y. Srinivasan's avatar K. Y. Srinivasan Committed by Greg Kroah-Hartman
Browse files

Staging: hv: vmbus: Cleanup the code in process_chn_event() 



A channel in Hyper-V is equivalent to a device. Thus, a channel is
persistent once it is presented to the guest, even if the driver
managing this device is unloaded. By checking and invoking the driver
specific callback function under the protection of the channel
inbound_lock, we can properly deal with racing driver unloads since an
unloading driver sets the callback to NULL under the protection of this
inbound_lock.

Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 7341d908

drivers/staging/hv/connection.c

+16 −2
Original line number Original line Diff line number Diff line
@@ -219,11 +219,25 @@ static void process_chn_event(u32 relid) 
	 */

	 */

	channel = relid2channel(relid);

	channel = relid2channel(relid);





	if (!channel) {

		pr_err("channel not found for relid - %u\n", relid);

		return;

	}



	/*

	 * A channel once created is persistent even when there

	 * is no driver handling the device. An unloading driver

	 * sets the onchannel_callback to NULL under the

	 * protection of the channel inbound_lock. Thus, checking

	 * and invoking the driver specific callback takes care of

	 * orderly unloading of the driver.

	 */



	spin_lock_irqsave(&channel->inbound_lock, flags);

	spin_lock_irqsave(&channel->inbound_lock, flags);

	if (channel && (channel->onchannel_callback != NULL))

	if (channel->onchannel_callback != NULL)

		channel->onchannel_callback(channel->channel_callback_context);

		channel->onchannel_callback(channel->channel_callback_context);

	else

	else

		pr_err("channel not found for relid - %u\n", relid);

		pr_err("no channel callback for relid - %u\n", relid);





	spin_unlock_irqrestore(&channel->inbound_lock, flags);

	spin_unlock_irqrestore(&channel->inbound_lock, flags);

}

}