Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7341d908 authored by K. Y. Srinivasan's avatar K. Y. Srinivasan Committed by Greg Kroah-Hartman
Browse files

Staging: hv: vmbus: Check for events before messages 



The Windows team has informed us that on Windows guests on Hyper-V,
they check for events before messages. They also recommended that we do
the same. This patch addresses this.

Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 8b9987e9

drivers/staging/hv/vmbus_drv.c

+14 −8
Original line number Diff line number Diff line
@@ -442,14 +442,11 @@ static irqreturn_t vmbus_isr(int irq, void *dev_id) 
	union hv_synic_event_flags *event;

	bool handled = false;



	page_addr = hv_context.synic_message_page[cpu];

	msg = (struct hv_message *)page_addr + VMBUS_MESSAGE_SINT;



	/* Check if there are actual msgs to be process */

	if (msg->header.message_type != HVMSG_NONE) {

		handled = true;

		tasklet_schedule(&msg_dpc);

	}

	/*

	 * Check for events before checking for messages. This is the order

	 * in which events and messages are checked in Windows guests on

	 * Hyper-V, and the Windows team suggested we do the same.

	 */



	page_addr = hv_context.synic_event_page[cpu];

	event = (union hv_synic_event_flags *)page_addr + VMBUS_MESSAGE_SINT;
@@ -460,6 +457,15 @@ static irqreturn_t vmbus_isr(int irq, void *dev_id) 
		tasklet_schedule(&event_dpc);

	}



	page_addr = hv_context.synic_message_page[cpu];

	msg = (struct hv_message *)page_addr + VMBUS_MESSAGE_SINT;



	/* Check if there are actual msgs to be processed */

	if (msg->header.message_type != HVMSG_NONE) {

		handled = true;

		tasklet_schedule(&msg_dpc);

	}



	if (handled)

		return IRQ_HANDLED;

	else