Commit 1b7443f4 authored Dec 24, 2021 by Jiasheng Jiang Committed by Greg Kroah-Hartman Jan 27, 2022

Bluetooth: hci_bcm: Check for error irq



[ Upstream commit b38cd3b42fba66cc538edb9cf77e07881f43f8e2 ]

For the possible failure of the platform_get_irq(), the returned irq
could be error number and will finally cause the failure of the
request_irq().
Consider that platform_get_irq() can now in certain cases return
-EPROBE_DEFER, and the consequences of letting request_irq() effectively
convert that into -EINVAL, even at probe time rather than later on.
So it might be better to check just now.

Fixes: 0395ffc1 ("Bluetooth: hci_bcm: Add PM for BCM devices")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 4ceb3190

drivers/bluetooth/hci_bcm.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -1127,7 +1127,12 @@ static int bcm_probe(struct platform_device *pdev)
		return -ENOMEM;

		dev->dev = &pdev->dev;
		dev->irq = platform_get_irq(pdev, 0);

		ret = platform_get_irq(pdev, 0);
		if (ret < 0)
		return ret;

		dev->irq = ret;

		if (has_acpi_companion(&pdev->dev)) {
		ret = bcm_acpi_probe(dev);