Commit 1b49707d authored Jul 01, 2022 by Liang He Committed by Greg Kroah-Hartman Aug 25, 2022

mips: cavium-octeon: Fix missing of_node_put() in octeon2_usb_clocks_start



[ Upstream commit 7a9f743ceead60ed454c46fbc3085ee9a79cbebb ]

We should call of_node_put() for the reference 'uctl_node' returned by
of_get_parent() which will increase the refcount. Otherwise, there will
be a refcount leak bug.

Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 3e699473

arch/mips/cavium-octeon/octeon-platform.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -86,11 +86,12 @@ static void octeon2_usb_clocks_start(struct device *dev)
		"refclk-frequency", &clock_rate);
		if (i) {
		dev_err(dev, "No UCTL \"refclk-frequency\"\n");
		of_node_put(uctl_node);
		goto exit;
		}
		i = of_property_read_string(uctl_node,
		"refclk-type", &clock_type);

		of_node_put(uctl_node);
		if (!i && strcmp("crystal", clock_type) == 0)
		is_crystal_clock = true;
		}