Commit 1aab663e authored Feb 08, 2023 by Hangbin Liu Committed by Greg Kroah-Hartman Feb 22, 2023

selftests: forwarding: lib: quote the sysctl values



[ Upstream commit 3a082086aa200852545cf15159213582c0c80eba ]

When set/restore sysctl value, we should quote the value as some keys
may have multi values, e.g. net.ipv4.ping_group_range

Fixes: f5ae5778 ("selftests: forwarding: lib: Add sysctl_set(), sysctl_restore()")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Link: https://lore.kernel.org/r/20230208032110.879205-1-liuhangbin@gmail.com


Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent ba38eaca

tools/testing/selftests/net/forwarding/lib.sh

+2 −2

Original line number	Diff line number	Diff line
		@@ -562,14 +562,14 @@ sysctl_set()
		local value=$1; shift

		SYSCTL_ORIG[$key]=$(sysctl -n $key)
		sysctl -qw $key=$value
		sysctl -qw $key="$value"
		}

		sysctl_restore()
		{
		local key=$1; shift

		sysctl -qw $key=${SYSCTL_ORIG["$key"]}
		sysctl -qw $key="${SYSCTL_ORIG[$key]}"
		}

		forwarding_enable()