Commit ba38eaca authored Feb 07, 2023 by Pietro Borrello Committed by Greg Kroah-Hartman Feb 22, 2023

rds: rds_rm_zerocopy_callback() use list_first_entry()



[ Upstream commit f753a68980cf4b59a80fe677619da2b1804f526d ]

rds_rm_zerocopy_callback() uses list_entry() on the head of a list
causing a type confusion.
Use list_first_entry() to actually access the first element of the
rs_zcookie_queue list.

Fixes: 9426bbc6 ("rds: use list structure to track information for zerocopy completion notification")
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
Link: https://lore.kernel.org/r/20230202-rds-zerocopy-v3-1-83b0df974f9a@diag.uniroma1.it


Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 87a5e3fc

net/rds/message.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -104,9 +104,9 @@ static void rds_rm_zerocopy_callback(struct rds_sock *rs,
		spin_lock_irqsave(&q->lock, flags);
		head = &q->zcookie_head;
		if (!list_empty(head)) {
		info = list_entry(head, struct rds_msg_zcopy_info,
		info = list_first_entry(head, struct rds_msg_zcopy_info,
		rs_zcookie_next);
		if (info && rds_zcookie_add(info, cookie)) {
		if (rds_zcookie_add(info, cookie)) {
		spin_unlock_irqrestore(&q->lock, flags);
		kfree(rds_info_from_znotifier(znotif));
		/* caller invokes rds_wake_sk_sleep() */