Commit 13c5fa0a authored Apr 25, 2021 by Krzysztof Kozlowski Committed by Greg Kroah-Hartman Jul 20, 2021

ARM: exynos: add missing of_node_put for loop iteration



[ Upstream commit 48d551bf20858240f38a0276be3016ff379918ac ]

Early exits from for_each_compatible_node() should decrement the
node reference counter.  Reported by Coccinelle:

  arch/arm/mach-exynos/exynos.c:52:1-25: WARNING:
    Function "for_each_compatible_node" should have of_node_put() before break around line 58.

Fixes: b3205dea ("ARM: EXYNOS: Map SYSRAM through generic DT bindings")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20210425174945.164612-1-krzysztof.kozlowski@canonical.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent dc3939d9

arch/arm/mach-exynos/exynos.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -46,6 +46,7 @@ void __init exynos_sysram_init(void)
		sysram_base_addr = of_iomap(node, 0);
		sysram_base_phys = of_translate_address(node,
		of_get_address(node, 0, NULL, NULL));
		of_node_put(node);
		break;
		}

		@@ -53,6 +54,7 @@ void __init exynos_sysram_init(void)
		if (!of_device_is_available(node))
		continue;
		sysram_ns_base_addr = of_iomap(node, 0);
		of_node_put(node);
		break;
		}
		}