Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 117e1495 authored by Miao Wang's avatar Miao Wang Committed by Greg Kroah-Hartman
Browse files

net/ipv4: swap flow ports when validating source 



[ Upstream commit c69f114d09891adfa3e301a35d9e872b8b7b5a50 ]

When doing source address validation, the flowi4 struct used for
fib_lookup should be in the reverse direction to the given skb.
fl4_dport and fl4_sport returned by fib4_rules_early_flow_dissect
should thus be swapped.

Fixes: 5a847a6e ("net/ipv4: Initialize proto and ports in flow struct")
Signed-off-by: default avatarMiao Wang <shankerwangmiao@gmail.com>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 74e76cd6

net/ipv4/fib_frontend.c

+2 −0
Original line number Diff line number Diff line
@@ -381,6 +381,8 @@ static int __fib_validate_source(struct sk_buff *skb, __be32 src, __be32 dst, 
		fl4.flowi4_proto = 0;

		fl4.fl4_sport = 0;

		fl4.fl4_dport = 0;

	} else {

		swap(fl4.fl4_sport, fl4.fl4_dport);

	}



	if (fib_lookup(net, &fl4, &res, 0))