Commit 0e58156d authored Apr 24, 2019 by Eric Dumazet Committed by David S. Miller Apr 26, 2019

tipc: remove rcu_read_unlock() left in tipc_udp_recv()



I forgot to remove one rcu_read_unlock() before a return statement.

Joy of mixing goto and return styles in a function :)

Fixes: 4109a2c3 ("tipc: tipc_udp_recv() cleanup vs rcu verbs")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8c90b795

net/tipc/udp_media.c

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -360,7 +360,6 @@ static int tipc_udp_recv(struct sock sk, struct sk_buff skb)

	if (b && test_bit(0, &b->up)) {		if (b && test_bit(0, &b->up)) {
	tipc_rcv(sock_net(sk), skb, b);		tipc_rcv(sock_net(sk), skb, b);
	rcu_read_unlock();
	return 0;		return 0;
	}		}