Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a59cea4 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Increase the size of the mailbox arrays from 4 to 8 



This patch avoids that Coverity complains that qla2x00_async_event() writes
outside the bounds of the mb[] arrays (MBA_IDC_AEN case).

Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Giridhar Malavali <gmalavali@marvell.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Acked-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 3f918ffa

drivers/scsi/qla2xxx/qla_isr.c

+2 −2
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ qla2100_intr_handler(int irq, void *dev_id) 
	int		status;

	unsigned long	iter;

	uint16_t	hccr;

	uint16_t	mb[4];

	uint16_t	mb[8];

	struct rsp_que *rsp;

	unsigned long	flags;
@@ -168,7 +168,7 @@ qla2300_intr_handler(int irq, void *dev_id) 
	unsigned long	iter;

	uint32_t	stat;

	uint16_t	hccr;

	uint16_t	mb[4];

	uint16_t	mb[8];

	struct rsp_que *rsp;

	struct qla_hw_data *ha;

	unsigned long	flags;

drivers/scsi/qla2xxx/qla_nx.c

+3 −3
Original line number Diff line number Diff line
@@ -2039,7 +2039,7 @@ qla82xx_intr_handler(int irq, void *dev_id) 
	unsigned long	flags;

	unsigned long	iter;

	uint32_t	stat = 0;

	uint16_t	mb[4];

	uint16_t	mb[8];



	rsp = (struct rsp_que *) dev_id;

	if (!rsp) {
@@ -2123,7 +2123,7 @@ qla82xx_msix_default(int irq, void *dev_id) 
	unsigned long flags;

	uint32_t stat = 0;

	uint32_t host_int = 0;

	uint16_t mb[4];

	uint16_t mb[8];



	rsp = (struct rsp_que *) dev_id;

	if (!rsp) {
@@ -2219,7 +2219,7 @@ qla82xx_poll(int irq, void *dev_id) 
	int status = 0;

	uint32_t stat;

	uint32_t host_int = 0;

	uint16_t mb[4];

	uint16_t mb[8];

	unsigned long flags;



	rsp = (struct rsp_que *) dev_id;

drivers/scsi/qla2xxx/qla_nx2.c

+1 −1
Original line number Diff line number Diff line
@@ -3895,7 +3895,7 @@ qla8044_intr_handler(int irq, void *dev_id) 
	unsigned long	flags;

	unsigned long	iter;

	uint32_t	stat;

	uint16_t	mb[4];

	uint16_t	mb[8];

	uint32_t leg_int_ptr = 0, pf_bit;



	rsp = (struct rsp_que *) dev_id;