Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f918ffa authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Log the status code if a firmware command fails 



It is important to know why a firmware command failed. Hence log 'rval'
together with the values of the mailbox registers if a firwmare command
fails.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Giridhar Malavali <gmalavali@marvell.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Acked-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 2dbb02fd

drivers/scsi/qla2xxx/qla_mbx.c

+2 −2
Original line number Diff line number Diff line
@@ -567,9 +567,9 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp) 
		    mcp->mb[0]);

	} else if (rval) {

		if (ql2xextended_error_logging & (ql_dbg_disc|ql_dbg_mbx)) {

			pr_warn("%s [%s]-%04x:%ld: **** Failed", QL_MSGHDR,

			pr_warn("%s [%s]-%04x:%ld: **** Failed=%x", QL_MSGHDR,

			    dev_name(&ha->pdev->dev), 0x1020+0x800,

			    vha->host_no);

			    vha->host_no, rval);

			mboxes = mcp->in_mb;

			cnt = 4;

			for (i = 0; i < ha->mbx_count && cnt; i++, mboxes >>= 1)

drivers/scsi/qla2xxx/qla_mr.c

+3 −3
Original line number Diff line number Diff line
@@ -273,9 +273,9 @@ qlafx00_mailbox_command(scsi_qla_host_t *vha, struct mbx_cmd_32 *mcp) 


	if (rval) {

		ql_log(ql_log_warn, base_vha, 0x1163,

		    "**** Failed mbx[0]=%x, mb[1]=%x, mb[2]=%x, "

		    "mb[3]=%x, cmd=%x ****.\n",

		    mcp->mb[0], mcp->mb[1], mcp->mb[2], mcp->mb[3], command);

		       "**** Failed=%x mbx[0]=%x, mb[1]=%x, mb[2]=%x, mb[3]=%x, cmd=%x ****.\n",

		       rval, mcp->mb[0], mcp->mb[1], mcp->mb[2], mcp->mb[3],

		       command);

	} else {

		ql_dbg(ql_dbg_mbx, base_vha, 0x1164, "Done %s.\n", __func__);

	}