Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0973a4dd authored by Vladimir Zapolskiy's avatar Vladimir Zapolskiy Committed by David S. Miller
Browse files

ravb: fix invalid context bug while calling auto-negotiation by ethtool 



Since commit 35b5f6b1 ("PHYLIB: Locking fixes for PHY I/O
potentially sleeping") phy_start_aneg() function utilizes a mutex
to serialize changes to phy state, however the helper function is
called in atomic context.

The bug can be reproduced by running "ethtool -r" command, the bug
is reported if CONFIG_DEBUG_ATOMIC_SLEEP build option is enabled.

Fixes: c156633f ("Renesas Ethernet AVB driver proper")
Signed-off-by: default avatarVladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Reviewed-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6783f50e

drivers/net/ethernet/renesas/ravb_main.c

+1 −6
Original line number Diff line number Diff line
@@ -1152,15 +1152,10 @@ static int ravb_set_link_ksettings(struct net_device *ndev, 


static int ravb_nway_reset(struct net_device *ndev)

{

	struct ravb_private *priv = netdev_priv(ndev);

	int error = -ENODEV;

	unsigned long flags;



	if (ndev->phydev) {

		spin_lock_irqsave(&priv->lock, flags);

	if (ndev->phydev)

		error = phy_start_aneg(ndev->phydev);

		spin_unlock_irqrestore(&priv->lock, flags);

	}



	return error;

}