Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6783f50e authored by Vladimir Zapolskiy's avatar Vladimir Zapolskiy Committed by David S. Miller
Browse files

sh_eth: remove custom .set_link_ksettings from ethtool ops 



The generic phy_ethtool_set_link_ksettings() function from phylib can
be used instead of in-house sh_eth_set_link_ksettings().

Signed-off-by: default avatarVladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Reviewed-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 45abbd43

drivers/net/ethernet/renesas/sh_eth.c

+1 −10
Original line number Diff line number Diff line
@@ -2040,15 +2040,6 @@ static int sh_eth_phy_start(struct net_device *ndev) 
	return 0;

}



static int sh_eth_set_link_ksettings(struct net_device *ndev,

				     const struct ethtool_link_ksettings *cmd)

{

	if (!ndev->phydev)

		return -ENODEV;



	return phy_ethtool_ksettings_set(ndev->phydev, cmd);

}



/* If it is ever necessary to increase SH_ETH_REG_DUMP_MAX_REGS, the

 * version must be bumped as well.  Just adding registers up to that

 * limit is fine, as long as the existing register indices don't
@@ -2388,7 +2379,7 @@ static const struct ethtool_ops sh_eth_ethtool_ops = { 
	.get_ringparam	= sh_eth_get_ringparam,

	.set_ringparam	= sh_eth_set_ringparam,

	.get_link_ksettings = phy_ethtool_get_link_ksettings,

	.set_link_ksettings = sh_eth_set_link_ksettings,

	.set_link_ksettings = phy_ethtool_set_link_ksettings,

	.get_wol	= sh_eth_get_wol,

	.set_wol	= sh_eth_set_wol,

};