bnx2x: fix pci device refcount leak in bnx2x_vf_is_pcie_pending() (08f25427) · Commits · e / devices / android_kernel_fairphone_FP5

[ Upstream commit 3637a29ccbb6461b7268c5c5db525935d510afc6 ] As comment of pci_get_domain_bus_and_slot() says, it returns a pci device with refcount increment, when finish using it, the caller must decrement the reference count by calling pci_dev_put(). Call pci_dev_put() before returning from bnx2x_vf_is_pcie_pending() to avoid refcount leak. Fixes: ("bnx2x: Prepare device and initialize VF database") Suggested-by:

Jakub Kicinski <kuba@kernel.org> Signed-off-by:

Yang Yingliang <yangyingliang@huawei.com> Reviewed-by:

Leon Romanovsky <leonro@nvidia.com> Link: https://lore.kernel.org/r/20221119070202.1407648-1-yangyingliang@huawei.com Signed-off-by:

Paolo Abeni <pabeni@redhat.com> Signed-off-by:

Sasha Levin <sashal@kernel.org>

drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c

+8 −4

Original line number	Original line	Diff line number	Diff line
	@@ -807,16 +807,20 @@ static void bnx2x_vf_enable_traffic(struct bnx2x bp, struct bnx2x_virtf vf)

	static u8 bnx2x_vf_is_pcie_pending(struct bnx2x *bp, u8 abs_vfid)		static u8 bnx2x_vf_is_pcie_pending(struct bnx2x *bp, u8 abs_vfid)
	{		{
	struct pci_dev *dev;
	struct bnx2x_virtf *vf = bnx2x_vf_by_abs_fid(bp, abs_vfid);		struct bnx2x_virtf *vf = bnx2x_vf_by_abs_fid(bp, abs_vfid);
			struct pci_dev *dev;
			bool pending;

	if (!vf)		if (!vf)
	return false;		return false;

	dev = pci_get_domain_bus_and_slot(vf->domain, vf->bus, vf->devfn);		dev = pci_get_domain_bus_and_slot(vf->domain, vf->bus, vf->devfn);
	if (dev)		if (!dev)
	return bnx2x_is_pcie_pending(dev);
	return false;		return false;
			pending = bnx2x_is_pcie_pending(dev);
			pci_dev_put(dev);

			return pending;
	}		}

	int bnx2x_vf_flr_clnup_epilog(struct bnx2x *bp, u8 abs_vfid)		int bnx2x_vf_flr_clnup_epilog(struct bnx2x *bp, u8 abs_vfid)