Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 055efab3 authored by Nick Desaulniers's avatar Nick Desaulniers Committed by Masahiro Yamada
Browse files

kbuild: drop support for cc-ldoption 



If you want to see if your linker supports a certain flag, then ask the
linker directly with ld-option (not the compiler with cc-ldoption).
Checking for linker flag support is an antipattern that complicates the
usage of various linkers other than bfd via -fuse-ld={bfd|gold|lld}.

Cc: clang-built-linux@googlegroups.com
Suggested-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
parent cb6f8739

Documentation/kbuild/makefiles.txt

+0 −14
Original line number Diff line number Diff line
@@ -437,20 +437,6 @@ more details, with real examples. 
	The second argument is optional, and if supplied will be used

	if first argument is not supported.



    cc-ldoption

	cc-ldoption is used to check if $(CC) when used to link object files

	supports the given option.  An optional second option may be

	specified if first option are not supported.



	Example:

		#arch/x86/kernel/Makefile

		vsyscall-flags += $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)



	In the above example, vsyscall-flags will be assigned the option

	-Wl$(comma)--hash-style=sysv if it is supported by $(CC).

	The second argument is optional, and if supplied will be used

	if first argument is not supported.



    as-instr

	as-instr checks if the assembler reports a specific instruction

	and then outputs either option1 or option2

scripts/Kbuild.include

+0 −5
Original line number Diff line number Diff line
@@ -138,11 +138,6 @@ cc-disable-warning = $(call try-run,\ 
# Usage:  EXTRA_CFLAGS += $(call cc-ifversion, -lt, 0402, -O1)

cc-ifversion = $(shell [ $(CONFIG_GCC_VERSION)0 $(1) $(2)000 ] && echo $(3) || echo $(4))



# cc-ldoption

# Usage: ldflags += $(call cc-ldoption, -Wl$(comma)--hash-style=both)

cc-ldoption = $(call try-run,\

	$(CC) $(1) $(KBUILD_CPPFLAGS) $(CC_OPTION_CFLAGS) -nostdlib -x c /dev/null -o "$$TMP",$(1),$(2))



# ld-option

# Usage: KBUILD_LDFLAGS += $(call ld-option, -X, -Y)

ld-option = $(call try-run, $(LD) $(KBUILD_LDFLAGS) $(1) -v,$(1),$(2),$(3))