Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02fafcf7 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: serial: quatech2: fix control-request directions 



commit eb8dbe80326c3d44c1e38ee4f40e0d8d3e06f2d0 upstream.

The direction of the pipe argument must match the request-type direction
bit or control requests may fail depending on the host-controller-driver
implementation.

Fix the three requests which erroneously used usb_rcvctrlpipe().

Fixes: f7a33e60 ("USB: serial: add quatech2 usb to serial driver")
Cc: stable@vger.kernel.org      # 3.5
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eedd4b49

drivers/usb/serial/quatech2.c

+3 −3
Original line number Diff line number Diff line
@@ -416,7 +416,7 @@ static void qt2_close(struct usb_serial_port *port) 


	/* flush the port transmit buffer */

	i = usb_control_msg(serial->dev,

			    usb_rcvctrlpipe(serial->dev, 0),

			    usb_sndctrlpipe(serial->dev, 0),

			    QT2_FLUSH_DEVICE, 0x40, 1,

			    port_priv->device_port, NULL, 0, QT2_USB_TIMEOUT);
@@ -426,7 +426,7 @@ static void qt2_close(struct usb_serial_port *port) 


	/* flush the port receive buffer */

	i = usb_control_msg(serial->dev,

			    usb_rcvctrlpipe(serial->dev, 0),

			    usb_sndctrlpipe(serial->dev, 0),

			    QT2_FLUSH_DEVICE, 0x40, 0,

			    port_priv->device_port, NULL, 0, QT2_USB_TIMEOUT);
@@ -670,7 +670,7 @@ static int qt2_attach(struct usb_serial *serial) 
	int status;



	/* power on unit */

	status = usb_control_msg(serial->dev, usb_rcvctrlpipe(serial->dev, 0),

	status = usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),

				 0xc2, 0x40, 0x8000, 0, NULL, 0,

				 QT2_USB_TIMEOUT);

	if (status < 0) {