Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fefc51e8 authored by Jani Nikula's avatar Jani Nikula
Browse files

drm/i915/dsi: rename intel_dsi_pre_disable to intel_dsi_disable 



The hook names reflect more the phase in the mode set sequence the hooks
are called in than what they actually do in terms of the specific
encoder. Stick to that scheme, and rename intel_dsi_pre_disable to
intel_dsi_disable. Unify the comments around this while at it. No
functional changes.

v2: Add more sense in the enable/disable hook comments (Ville)

Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarBob Paauwe <bob.j.paauwe@intel.com>
Cc: Madhav Chauhan <madhav.chauhan@intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Bob Paauwe <bob.j.paauwe@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1488878659-10386-1-git-send-email-jani.nikula@intel.com
parent b0dd6887

drivers/gpu/drm/i915/intel_dsi.c

+12 −9
Original line number Diff line number Diff line
@@ -840,19 +840,22 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder, 
	intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_BACKLIGHT_ON);

}



/*

 * DSI port enable has to be done before pipe and plane enable, so we do it in

 * the pre_enable hook.

 */

static void intel_dsi_enable_nop(struct intel_encoder *encoder,

				 struct intel_crtc_state *pipe_config,

				 struct drm_connector_state *conn_state)

{

	DRM_DEBUG_KMS("\n");



	/* for DSI port enable has to be done before pipe

	 * and plane enable, so port enable is done in

	 * pre_enable phase itself unlike other encoders

	 */

}



static void intel_dsi_pre_disable(struct intel_encoder *encoder,

/*

 * DSI port disable has to be done after pipe and plane disable, so we do it in

 * the post_disable hook.

 */

static void intel_dsi_disable(struct intel_encoder *encoder,

			      struct intel_crtc_state *old_crtc_state,

			      struct drm_connector_state *old_conn_state)

{
@@ -1730,7 +1733,7 @@ void intel_dsi_init(struct drm_i915_private *dev_priv) 
	intel_encoder->compute_config = intel_dsi_compute_config;

	intel_encoder->pre_enable = intel_dsi_pre_enable;

	intel_encoder->enable = intel_dsi_enable_nop;

	intel_encoder->disable = intel_dsi_pre_disable;

	intel_encoder->disable = intel_dsi_disable;

	intel_encoder->post_disable = intel_dsi_post_disable;

	intel_encoder->get_hw_state = intel_dsi_get_hw_state;

	intel_encoder->get_config = intel_dsi_get_config;