Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fe76b796 authored by Jaegeuk Kim's avatar Jaegeuk Kim
Browse files

f2fs: introduce f2fs_set_page_dirty_nobuffer 



This patch adds f2fs_set_page_dirty_nobuffer() copied from __set_page_dirty_buffer.
When appending 4KB blocks in f2fs on pmem with multiple cores, this improves the
overall performance.

Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent a0995af6

fs/f2fs/checkpoint.c

+1 −1
Original line number Diff line number Diff line
@@ -366,7 +366,7 @@ static int f2fs_set_meta_page_dirty(struct page *page) 


	SetPageUptodate(page);

	if (!PageDirty(page)) {

		__set_page_dirty_nobuffers(page);

		f2fs_set_page_dirty_nobuffers(page);

		inc_page_count(F2FS_P_SB(page), F2FS_DIRTY_META);

		SetPagePrivate(page);

		f2fs_trace_pid(page);

fs/f2fs/data.c

+32 −1
Original line number Diff line number Diff line
@@ -19,6 +19,8 @@ 
#include <linux/bio.h>

#include <linux/prefetch.h>

#include <linux/uio.h>

#include <linux/mm.h>

#include <linux/memcontrol.h>

#include <linux/cleancache.h>



#include "f2fs.h"
@@ -1775,6 +1777,35 @@ int f2fs_release_page(struct page *page, gfp_t wait) 
	return 1;

}



/*

 * This was copied from __set_page_dirty_buffers which gives higher performance

 * in very high speed storages. (e.g., pmem)

 */

void f2fs_set_page_dirty_nobuffers(struct page *page)

{

	struct address_space *mapping = page->mapping;

	unsigned long flags;



	if (unlikely(!mapping))

		return;



	spin_lock(&mapping->private_lock);

	lock_page_memcg(page);

	SetPageDirty(page);

	spin_unlock(&mapping->private_lock);



	spin_lock_irqsave(&mapping->tree_lock, flags);

	WARN_ON_ONCE(!PageUptodate(page));

	account_page_dirtied(page, mapping);

	radix_tree_tag_set(&mapping->page_tree,

			page_index(page), PAGECACHE_TAG_DIRTY);

	spin_unlock_irqrestore(&mapping->tree_lock, flags);

	unlock_page_memcg(page);



	__mark_inode_dirty(mapping->host, I_DIRTY_PAGES);

	return;

}



static int f2fs_set_data_page_dirty(struct page *page)

{

	struct address_space *mapping = page->mapping;
@@ -1797,7 +1828,7 @@ static int f2fs_set_data_page_dirty(struct page *page) 
	}



	if (!PageDirty(page)) {

		__set_page_dirty_nobuffers(page);

		f2fs_set_page_dirty_nobuffers(page);

		update_dirty_page(inode, page);

		return 1;

	}

fs/f2fs/f2fs.h

+1 −0
Original line number Diff line number Diff line
@@ -2077,6 +2077,7 @@ struct page *get_new_data_page(struct inode *, struct page *, pgoff_t, bool); 
int do_write_data_page(struct f2fs_io_info *);

int f2fs_map_blocks(struct inode *, struct f2fs_map_blocks *, int, int);

int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *, u64, u64);

void f2fs_set_page_dirty_nobuffers(struct page *);

void f2fs_invalidate_page(struct page *, unsigned int, unsigned int);

int f2fs_release_page(struct page *, gfp_t);

fs/f2fs/node.c

+1 −1
Original line number Diff line number Diff line
@@ -1646,7 +1646,7 @@ static int f2fs_set_node_page_dirty(struct page *page) 


	SetPageUptodate(page);

	if (!PageDirty(page)) {

		__set_page_dirty_nobuffers(page);

		f2fs_set_page_dirty_nobuffers(page);

		inc_page_count(F2FS_P_SB(page), F2FS_DIRTY_NODES);

		SetPagePrivate(page);

		f2fs_trace_pid(page);