Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a0995af6 authored by Tiezhu Yang's avatar Tiezhu Yang Committed by Jaegeuk Kim
Browse files

f2fs: remove unnecessary goto statement 



When base_addr is NULL, there is no need to call kzfree,
it should return -ENOMEM directly. Additionally, it is
better to initialize variable 'error' with 0.

Signed-off-by: default avatarTiezhu Yang <kernelpatch@126.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 64058be9

fs/f2fs/xattr.c

+2 −2
Original line number Diff line number Diff line
@@ -447,7 +447,7 @@ static int __f2fs_setxattr(struct inode *inode, int index, 
	int found, newsize;

	size_t len;

	__u32 new_hsize;

	int error = -ENOMEM;

	int error = 0;



	if (name == NULL)

		return -EINVAL;
@@ -465,7 +465,7 @@ static int __f2fs_setxattr(struct inode *inode, int index, 


	base_addr = read_all_xattrs(inode, ipage);

	if (!base_addr)

		goto exit;

		return -ENOMEM;



	/* find entry with wanted name. */

	here = __find_xattr(base_addr, index, len, name);