Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fcfaf125 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Greg Kroah-Hartman
Browse files

pinctrl: samsung: Fix device node refcount leaks in S3C24xx wakeup controller init 



commit 6fbbcb050802d6ea109f387e961b1dbcc3a80c96 upstream.

In s3c24xx_eint_init() the for_each_child_of_node() loop is used with a
break to find a matching child node.  Although each iteration of
for_each_child_of_node puts the previous node, but early exit from loop
misses it.  This leads to leak of device node.

Cc: <stable@vger.kernel.org>
Fixes: af99a750 ("pinctrl: Add pinctrl-s3c24xx driver")
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1aaf409e

drivers/pinctrl/samsung/pinctrl-s3c24xx.c

+5 −1
Original line number Diff line number Diff line
@@ -490,8 +490,10 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d) 
		return -ENODEV;



	eint_data = devm_kzalloc(dev, sizeof(*eint_data), GFP_KERNEL);

	if (!eint_data)

	if (!eint_data) {

		of_node_put(eint_np);

		return -ENOMEM;

	}



	eint_data->drvdata = d;
@@ -503,12 +505,14 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d) 
		irq = irq_of_parse_and_map(eint_np, i);

		if (!irq) {

			dev_err(dev, "failed to get wakeup EINT IRQ %d\n", i);

			of_node_put(eint_np);

			return -ENXIO;

		}



		eint_data->parents[i] = irq;

		irq_set_chained_handler_and_data(irq, handlers[i], eint_data);

	}

	of_node_put(eint_np);



	bank = d->pin_banks;

	for (i = 0; i < d->nr_banks; ++i, ++bank) {