Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1aaf409e authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Greg Kroah-Hartman
Browse files

pinctrl: samsung: Fix device node refcount leaks in Exynos wakeup controller init 



commit 5c7f48dd14e892e3e920dd6bbbd52df79e1b3b41 upstream.

In exynos_eint_wkup_init() the for_each_child_of_node() loop is used
with a break to find a matching child node.  Although each iteration of
for_each_child_of_node puts the previous node, but early exit from loop
misses it.  This leads to leak of device node.

Cc: <stable@vger.kernel.org>
Fixes: 43b169db ("pinctrl: add exynos4210 specific extensions for samsung pinctrl driver")
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0c72a9f1

drivers/pinctrl/samsung/pinctrl-exynos.c

+8 −2
Original line number Diff line number Diff line
@@ -514,6 +514,7 @@ int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d) 
				bank->nr_pins, &exynos_eint_irqd_ops, bank);

		if (!bank->irq_domain) {

			dev_err(dev, "wkup irq domain add failed\n");

			of_node_put(wkup_np);

			return -ENXIO;

		}
@@ -528,8 +529,10 @@ int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d) 
		weint_data = devm_kcalloc(dev,

					  bank->nr_pins, sizeof(*weint_data),

					  GFP_KERNEL);

		if (!weint_data)

		if (!weint_data) {

			of_node_put(wkup_np);

			return -ENOMEM;

		}



		for (idx = 0; idx < bank->nr_pins; ++idx) {

			irq = irq_of_parse_and_map(bank->of_node, idx);
@@ -546,10 +549,13 @@ int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d) 
		}

	}



	if (!muxed_banks)

	if (!muxed_banks) {

		of_node_put(wkup_np);

		return 0;

	}



	irq = irq_of_parse_and_map(wkup_np, 0);

	of_node_put(wkup_np);

	if (!irq) {

		dev_err(dev, "irq number for muxed EINTs not found\n");

		return 0;