ANDROID: fix up abi issue with struct snd_pcm_runtime
A portion of the fix for CVE-2022-1048, commit 9cb6c40a ("ALSA: pcm: Fix races among concurrent hw_params and hw_free calls") and 40f4cffb ("ALSA: pcm: Fix potential AB/BA lock with buffer_mutex and mmap_lock"), caused an ABI break by adding a new field to struct snd_pcm_runtime. Because we have to keep this new addition, it is safe to move it to the end of the structure because this is only ever created by the sound core, and referenced as a pointer everywhere else. This does require a .xml update also to handle the increased structure size: Leaf changes summary: 1 artifact changed Changed leaf types summary: 1 leaf type changed Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 0 Added function Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 0 Added variable 'struct snd_pcm_runtime at pcm.h:367:1' changed: type size changed from 6144 to 6464 (in bits) 2 data member insertions: 'mutex buffer_mutex', at offset 6144 (in bits) at pcm.h:454:1 'atomic_t buffer_accessing', at offset 6400 (in bits) at pcm.h:455:1 59 impacted interfaces Bug: 161946584 Fixes: 9cb6c40a ("ALSA: pcm: Fix races among concurrent hw_params and hw_free calls") Fixes: 40f4cffb ("ALSA: pcm: Fix potential AB/BA lock with buffer_mutex and mmap_lock") Signed-off-by:Greg Kroah-Hartman <gregkh@google.com> Change-Id: I525799616e06c1d2c5513821a3361e99dcb7e553
Loading
Please register or sign in to comment