Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef1e0bfc authored by Michał Mirosław's avatar Michał Mirosław Committed by Greg Kroah-Hartman
Browse files

ALSA: pcm: disallow linking stream to itself 



commit 951e2736f4b11b58dc44d41964fa17c3527d882a upstream.

Prevent SNDRV_PCM_IOCTL_LINK linking stream to itself - the code
can't handle it. Fixed commit is not where bug was introduced, but
changes the context significantly.

Cc: stable@vger.kernel.org
Fixes: 0888c321 ("pcm_native: switch to fdget()/fdput()")
Signed-off-by: default avatarMichał Mirosław <mirq-linux@rere.qmqm.pl>
Link: https://lore.kernel.org/r/89c4a2487609a0ed6af3ecf01cc972bdc59a7a2d.1591634956.git.mirq-linux@rere.qmqm.pl


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7c3261d8

sound/core/pcm_native.c

+5 −0
Original line number Diff line number Diff line
@@ -1982,6 +1982,11 @@ static int snd_pcm_link(struct snd_pcm_substream *substream, int fd) 
	}

	pcm_file = f.file->private_data;

	substream1 = pcm_file->substream;

	if (substream == substream1) {

		res = -EINVAL;

		goto _badf;

	}



	group = kmalloc(sizeof(*group), GFP_KERNEL);

	if (!group) {

		res = -ENOMEM;