Commit 7c3261d8 authored May 30, 2020 by Christophe JAILLET Committed by Greg Kroah-Hartman Jun 22, 2020

crypto: cavium/nitrox - Fix 'nitrox_get_first_device()' when ndevlist is fully iterated



commit 320bdbd816156f9ca07e5fed7bfb449f2908dda7 upstream.

When a list is completely iterated with 'list_for_each_entry(x, ...)', x is
not NULL at the end.

While at it, remove a useless initialization of the ndev variable. It
is overridden by 'list_for_each_entry'.

Fixes: f2663872 ("crypto: cavium - Register the CNN55XX supported crypto algorithms.")
Cc: <stable@vger.kernel.org>
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3834e636

drivers/crypto/cavium/nitrox/nitrox_main.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -183,7 +183,7 @@ static void nitrox_remove_from_devlist(struct nitrox_device *ndev)

		struct nitrox_device *nitrox_get_first_device(void)
		{
		struct nitrox_device *ndev = NULL;
		struct nitrox_device *ndev;

		mutex_lock(&devlist_lock);
		list_for_each_entry(ndev, &ndevlist, list) {
		@@ -191,7 +191,7 @@ struct nitrox_device *nitrox_get_first_device(void)
		break;
		}
		mutex_unlock(&devlist_lock);
		if (!ndev)
		if (&ndev->list == &ndevlist)
		return NULL;

		refcount_inc(&ndev->refcnt);