Commit eb045e04 authored May 22, 2017 by Gustavo A. R. Silva Committed by Martin K. Petersen Jun 12, 2017

scsi: hisi_sas: add null check before indirect pointer dereference



Add null check before indirectly dereferencing pointer task->lldd_task
in statement u32 tag = slot->idx;

Addresses-Coverity-ID: 1373843
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 5c146686

drivers/scsi/hisi_sas/hisi_sas_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -963,7 +963,7 @@ static int hisi_sas_abort_task(struct sas_task *task)
		HISI_SAS_INT_ABT_DEV, 0);
		rc = hisi_sas_softreset_ata_disk(device);
		}
		} else if (task->task_proto & SAS_PROTOCOL_SMP) {
		} else if (task->lldd_task && task->task_proto & SAS_PROTOCOL_SMP) {
		/* SMP */
		struct hisi_sas_slot *slot = task->lldd_task;
		u32 tag = slot->idx;