Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c146686 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Martin K. Petersen
Browse files

scsi: smartpqi: mark PM functions as __maybe_unused 



The newly added suspend/resume support causes harmless warnings when
CONFIG_PM is disabled:

smartpqi/smartpqi_init.c:5147:12: error: 'pqi_ctrl_wait_for_pending_io' defined but not used [-Werror=unused-function]
smartpqi/smartpqi_init.c:2019:13: error: 'pqi_wait_until_lun_reset_finished' defined but not used [-Werror=unused-function]
smartpqi/smartpqi_init.c:2013:13: error: 'pqi_wait_until_scan_finished' defined but not used [-Werror=unused-function]

We can avoid the warnings by removing the #ifdef around the handlers and
instead marking them as __maybe_unused, which will let gcc drop the
unused code silently.

Fixes: f44d210312a6 ("scsi: smartpqi: add suspend and resume support")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 42c335f7

drivers/scsi/smartpqi/smartpqi_init.c

+2 −10
Original line number Diff line number Diff line
@@ -6213,8 +6213,6 @@ static int pqi_ctrl_init(struct pqi_ctrl_info *ctrl_info) 
	return 0;

}



#if defined(CONFIG_PM)



static void pqi_reinit_queues(struct pqi_ctrl_info *ctrl_info)

{

	unsigned int i;
@@ -6321,8 +6319,6 @@ static int pqi_ctrl_init_resume(struct pqi_ctrl_info *ctrl_info) 
	return 0;

}



#endif /* CONFIG_PM */



static inline int pqi_set_pcie_completion_timeout(struct pci_dev *pci_dev,

	u16 timeout)

{
@@ -6696,9 +6692,7 @@ static void pqi_process_module_params(void) 
	pqi_process_lockup_action_param();

}



#if defined(CONFIG_PM)



static int pqi_suspend(struct pci_dev *pci_dev, pm_message_t state)

static __maybe_unused int pqi_suspend(struct pci_dev *pci_dev, pm_message_t state)

{

	struct pqi_ctrl_info *ctrl_info;
@@ -6728,7 +6722,7 @@ static int pqi_suspend(struct pci_dev *pci_dev, pm_message_t state) 
	return 0;

}



static int pqi_resume(struct pci_dev *pci_dev)

static __maybe_unused int pqi_resume(struct pci_dev *pci_dev)

{

	int rc;

	struct pqi_ctrl_info *ctrl_info;
@@ -6759,8 +6753,6 @@ static int pqi_resume(struct pci_dev *pci_dev) 
	return pqi_ctrl_init_resume(ctrl_info);

}



#endif /* CONFIG_PM */



/* Define the PCI IDs for the controllers that we support. */

static const struct pci_device_id pqi_pci_id_table[] = {

	{