Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e79dd09b authored by Andrzej Hajda's avatar Andrzej Hajda Committed by David S. Miller
Browse files

orinoco: fix checking for default value 

Thresholds uses -1 to indicate that default value should be used.
Since thresholds are unsigned sign checking makes no sense.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576



Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cc751498

drivers/net/wireless/orinoco/cfg.c

+3 −3
Original line number Diff line number Diff line
@@ -220,7 +220,7 @@ static int orinoco_set_wiphy_params(struct wiphy *wiphy, u32 changed) 
	if (changed & WIPHY_PARAM_FRAG_THRESHOLD) {

		/* Set fragmentation */

		if (priv->has_mwo) {

			if (wiphy->frag_threshold < 0)

			if (wiphy->frag_threshold == -1)

				frag_value = 0;

			else {

				printk(KERN_WARNING "%s: Fixed fragmentation "
@@ -230,7 +230,7 @@ static int orinoco_set_wiphy_params(struct wiphy *wiphy, u32 changed) 
				frag_value = 1;

			}

		} else {

			if (wiphy->frag_threshold < 0)

			if (wiphy->frag_threshold == -1)

				frag_value = 2346;

			else if ((wiphy->frag_threshold < 257) ||

				 (wiphy->frag_threshold > 2347))
@@ -252,7 +252,7 @@ static int orinoco_set_wiphy_params(struct wiphy *wiphy, u32 changed) 
		 * the upper limit.

		 */



		if (wiphy->rts_threshold < 0)

		if (wiphy->rts_threshold == -1)

			rts_value = 2347;

		else if (wiphy->rts_threshold > 2347)

			err = -EINVAL;