Commit cc751498 authored Sep 21, 2015 by Andrzej Hajda Committed by David S. Miller Sep 22, 2015

mwifiex: fix comparison expression

To avoid underflows signed variables should be used in expression.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576



Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Acked-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 94926121

drivers/net/wireless/mwifiex/11n_rxreorder.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -615,10 +615,10 @@ int mwifiex_11n_rx_reorder_pkt(struct mwifiex_private *priv,
		((end_win > start_win) && ((seq_num > end_win) \|\|
		(seq_num < start_win)))) {
		end_win = seq_num;
		if (((seq_num - win_size) + 1) >= 0)
		if (((end_win - win_size) + 1) >= 0)
		start_win = (end_win - win_size) + 1;
		else
		start_win = (MAX_TID_VALUE - (win_size - seq_num)) + 1;
		start_win = (MAX_TID_VALUE - (win_size - end_win)) + 1;
		mwifiex_11n_dispatch_pkt_until_start_win(priv, tbl, start_win);
		}