Commit e60b13e4 authored Feb 17, 2016 by Anton Protopopov Committed by David S. Miller Feb 18, 2016

mISDN: prevent possible NULL pointer dereference



A return value of the bchannel_get_rxbuf() function is compared with the
positive ENOMEM value instead of the negative -ENOMEM value to detect a
memory allocation problem. Thus, after a possible memory allocation
failure the bc->bch.rx_skb will be NULL which will lead to a NULL
pointer dereference.

Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 449f14f0

drivers/isdn/hardware/mISDN/netjet.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -392,7 +392,7 @@ read_dma(struct tiger_ch *bc, u32 idx, int cnt)
		}
		stat = bchannel_get_rxbuf(&bc->bch, cnt);
		/* only transparent use the count here, HDLC overun is detected later */
		if (stat == ENOMEM) {
		if (stat == -ENOMEM) {
		pr_warning("%s.B%d: No memory for %d bytes\n",
		card->name, bc->bch.nr, cnt);
		return;