Commit e112666b authored Feb 04, 2017 by Theodore Ts'o

jbd2: don't leak modified metadata buffers on an aborted journal



If the journal has been aborted, we shouldn't mark the underlying
buffer head as dirty, since that will cause the metadata block to get
modified.  And if the journal has been aborted, we shouldn't allow
this since it will almost certainly lead to a corrupted file system.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org

parent eb5efbcb

fs/jbd2/transaction.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1863,7 +1863,9 @@ static void __jbd2_journal_temp_unlink_buffer(struct journal_head *jh)

		__blist_del_buffer(list, jh);
		jh->b_jlist = BJ_None;
		if (test_clear_buffer_jbddirty(bh))
		if (transaction && is_journal_aborted(transaction->t_journal))
		clear_buffer_jbddirty(bh);
		else if (test_clear_buffer_jbddirty(bh))
		mark_buffer_dirty(bh); /* Expose it to the VM */
		}