Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ce61856b authored by Eric Paris's avatar Eric Paris
Browse files

dnotify: do not bother to lock entry->lock when reading mask 



entry->lock is needed to make sure entry->mask does not change while
manipulating it.  In dnotify_should_send_event() we don't care if we get an
old or a new mask value out of this entry so there is no point it taking
the lock.

Signed-off-by: default avatarEric Paris <eparis@redhat.com>
parent 5ac697b7

fs/notify/dnotify/dnotify.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -153,9 +153,8 @@ static bool dnotify_should_send_event(struct fsnotify_group *group, 
	if (!entry)

	if (!entry)

		return false;

		return false;





	spin_lock(&entry->lock);

	send = (mask & entry->mask);

	send = (mask & entry->mask);

	spin_unlock(&entry->lock);



	fsnotify_put_mark(entry); /* matches fsnotify_find_mark_entry */

	fsnotify_put_mark(entry); /* matches fsnotify_find_mark_entry */





	return send;

	return send;