Commit cca3d0b7 authored Mar 15, 2018 by Pratham Pratap Committed by Gerrit - the friendly Code Review server Apr 24, 2019

usb: dwc3: Avoid NULL pointer access



dwc3_calc_trbs_left function is calling dwc3_ep_prev_trb
which can return NULL if trb pool is empty. This change adds
check for the return value of dwc3_ep_prev_trb function to
avoid NULL pointer dereference.

Change-Id: Id11d5ffd23da7c070d5e0b26842d8738b073b212
Signed-off-by: Pratham Pratap <prathampratap@codeaurora.org>

parent f74ff626

drivers/usb/dwc3/gadget.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1088,7 +1088,7 @@ static u32 dwc3_calc_trbs_left(struct dwc3_ep *dep)
		*/
		if (dep->trb_enqueue == dep->trb_dequeue) {
		tmp = dwc3_ep_prev_trb(dep, dep->trb_enqueue);
		if (tmp->ctrl & DWC3_TRB_CTRL_HWO)
		if (!tmp \|\| tmp->ctrl & DWC3_TRB_CTRL_HWO)
		return 0;

		return DWC3_TRB_NUM - 1;