Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc7666a3 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

[media] m5mols: potential uninitialized variable 



Smatch complains that there are some paths where "status" isn't
initialized.  The code does assume that m5mols_read_u8() can fail so it
seems as if Smatch is correct.

Let's initialize it to REG_ISO_AUTO which is zero.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 60587bd0

drivers/media/i2c/m5mols/m5mols_controls.c

+1 −1
Original line number Diff line number Diff line
@@ -405,7 +405,7 @@ static int m5mols_g_volatile_ctrl(struct v4l2_ctrl *ctrl) 
	struct v4l2_subdev *sd = to_sd(ctrl);

	struct m5mols_info *info = to_m5mols(sd);

	int ret = 0;

	u8 status;

	u8 status = REG_ISO_AUTO;



	v4l2_dbg(1, m5mols_debug, sd, "%s: ctrl: %s (%d)\n",

		 __func__, ctrl->name, info->isp_ready);