Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60587bd0 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

[media] cx23885: uninitialized variable in cx23885_av_work_handler() 



The "handled" variable could be uninitialized if the
interrupt_service_routine() call back hasn't been implimented or if it
has been implemented but doesn't initialize "handled" to zero at the
start.  For example, adv76xx_isr() only sets "handled" to true.

Fixes: 44b153ca ('[media] m5mols: Add ISO sensitivity controls')

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent e4bccada

drivers/media/pci/cx23885/cx23885-av.c

+1 −1
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ void cx23885_av_work_handler(struct work_struct *work) 
{

	struct cx23885_dev *dev =

			   container_of(work, struct cx23885_dev, cx25840_work);

	bool handled;

	bool handled = false;



	v4l2_subdev_call(dev->sd_cx25840, core, interrupt_service_routine,

			 PCI_MSK_AV_CORE, &handled);