Commit cc336546 authored Jul 31, 2014 by Axel Lin Committed by Guenter Roeck Aug 04, 2014

hwmon: (sis5595) Prevent overflow problem when writing large limits



On platforms with sizeof(int) < sizeof(long), writing a temperature
limit larger than MAXINT will result in unpredictable limit values
written to the chip. Avoid auto-conversion from long to int to fix
the problem.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 2565fb05

drivers/hwmon/sis5595.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -159,7 +159,7 @@ static inline int TEMP_FROM_REG(s8 val)
		{
		return val * 830 + 52120;
		}
		static inline s8 TEMP_TO_REG(int val)
		static inline s8 TEMP_TO_REG(long val)
		{
		int nval = clamp_val(val, -54120, 157530) ;
		return nval < 0 ? (nval - 5212 - 415) / 830 : (nval - 5212 + 415) / 830;