Commit 2565fb05 authored Aug 02, 2014 by Axel Lin Committed by Guenter Roeck Aug 04, 2014

hwmon: (gpio-fan) Prevent overflow problem when writing large limits



On platforms with sizeof(int) < sizeof(unsigned long), writing a rpm value
larger than MAXINT will result in unpredictable limit values written to the
chip. Avoid auto-conversion from unsigned long to int to fix the problem.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 18d03f3c

drivers/hwmon/gpio-fan.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -173,7 +173,7 @@ static int get_fan_speed_index(struct gpio_fan_data *fan_data)
		return -ENODEV;
		}

		static int rpm_to_speed_index(struct gpio_fan_data *fan_data, int rpm)
		static int rpm_to_speed_index(struct gpio_fan_data *fan_data, unsigned long rpm)
		{
		struct gpio_fan_speed *speed = fan_data->speed;
		int i;