Commit c780aac6 authored Sep 18, 2020 by Marek Behún Committed by Greg Kroah-Hartman Nov 05, 2020

leds: bcm6328, bcm6358: use devres LED registering function



commit ff5c89d44453e7ad99502b04bf798a3fc32c758b upstream.

These two drivers do not provide remove method and use devres for
allocation of other resources, yet they use led_classdev_register
instead of the devres variant, devm_led_classdev_register.

Fix this.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Cc: Álvaro Fernández Rojas <noltari@gmail.com>
Cc: Kevin Cernekee <cernekee@gmail.com>
Cc: Jaedon Shin <jaedon.shin@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c5a38ae8

drivers/leds/leds-bcm6328.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -336,7 +336,7 @@ static int bcm6328_led(struct device dev, struct device_node nc, u32 reg,
		led->cdev.brightness_set = bcm6328_led_set;
		led->cdev.blink_set = bcm6328_blink_set;

		rc = led_classdev_register(dev, &led->cdev);
		rc = devm_led_classdev_register(dev, &led->cdev);
		if (rc < 0)
		return rc;

drivers/leds/leds-bcm6358.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -141,7 +141,7 @@ static int bcm6358_led(struct device dev, struct device_node nc, u32 reg,

		led->cdev.brightness_set = bcm6358_led_set;

		rc = led_classdev_register(dev, &led->cdev);
		rc = devm_led_classdev_register(dev, &led->cdev);
		if (rc < 0)
		return rc;