Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6fff322 authored by Nicholas Krause's avatar Nicholas Krause Committed by Martin K. Petersen
Browse files

be2iscsi:Add missing error check in beiscsi_eeh_resume 



This adds the missing error check and path for if the call to the
function hwi_init_controller fails as this error path was clearly missed
when writing beiscsi_eeh_resume and thus we must add it now in order to
be able to handle this nonrecoverable failing function call gracefully
in beiscsi_eeh_resume.

Signed-off-by: default avatarNicholas Krause <xerofoify@gmail.com>
Reviewed-by: default avatarJitendra Bhivare <jitendra.bhivare@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent eac00c8a

drivers/scsi/be2iscsi/be_main.c

+6 −0
Original line number Original line Diff line number Diff line
@@ -5572,6 +5572,12 @@ static void beiscsi_eeh_resume(struct pci_dev *pdev) 
	phba->shost->max_id = phba->params.cxns_per_ctrl;

	phba->shost->max_id = phba->params.cxns_per_ctrl;

	phba->shost->can_queue = phba->params.ios_per_ctrl;

	phba->shost->can_queue = phba->params.ios_per_ctrl;

	ret = hwi_init_controller(phba);

	ret = hwi_init_controller(phba);

	if (ret) {

		beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_INIT,

			    "BM_%d : beiscsi_eeh_resume -"

			     "Failed to initialize beiscsi_hba.\n");

		goto ret_err;

	}





	for (i = 0; i < MAX_MCC_CMD; i++) {

	for (i = 0; i < MAX_MCC_CMD; i++) {

		init_waitqueue_head(&phba->ctrl.mcc_wait[i + 1]);

		init_waitqueue_head(&phba->ctrl.mcc_wait[i + 1]);