Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eac00c8a authored by Usha Ketineni's avatar Usha Ketineni Committed by Martin K. Petersen
Browse files

fcoe: fix reset of fip selection time. 



Do not reset fip selection time for every advertisement
in fcoe_ctlr_recv_adv() but set it only once for the first
validated FCF. Otherwise FCF selection won't happen when the
advertisements consistently arrive with sub FCOE_CTLR_START_DELAY
periodicity.

Tested-by: default avatarNarendra K <narendra_k@dell.com>
Acked-by: default avatarNeil Horman <nhorman@tuxdriver.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Acked-by: default avatarVasu Dev <vasu.dev@intel.com>
Signed-off-by: default avatarUsha Ketineni <usha.k.ketineni@intel.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 268d11e9

drivers/scsi/fcoe/fcoe_ctlr.c

+2 −1
Original line number Diff line number Diff line
@@ -1118,7 +1118,8 @@ static void fcoe_ctlr_recv_adv(struct fcoe_ctlr *fip, struct sk_buff *skb) 
	 * If this is the first validated FCF, note the time and

	 * set a timer to trigger selection.

	 */

	if (mtu_valid && !fip->sel_fcf && fcoe_ctlr_fcf_usable(fcf)) {

	if (mtu_valid && !fip->sel_fcf && !fip->sel_time &&

	    fcoe_ctlr_fcf_usable(fcf)) {

		fip->sel_time = jiffies +

			msecs_to_jiffies(FCOE_CTLR_START_DELAY);

		if (!timer_pending(&fip->timer) ||