Commit c3547a27 authored Mar 25, 2021 by Shravya Samala Committed by Gerrit - the friendly Code Review server Dec 22, 2021

msm: camera: isp: Dont enable Wm configurations during HW start



There is a chance that during acquire time while updating write master,
for few resources io buffers are not allocated. If Wm configurations
are enabled without receiving io buffers then there is a chance of
hitting page fault issues.
This commit takes care of enabling Wm configurations for each
client only if io buffers are allocated.

CRs-Fixed: 2887053
Change-Id: I868bd01dbd896dd86eeec4fc92a8a62e746f79cf
Signed-off-by: Shravya Samala <shravyas@codeaurora.org>

parent 84b63b60

drivers/cam_isp/isp_hw_mgr/isp_hw/vfe_hw/vfe_bus/cam_vfe_bus_ver2.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -1299,10 +1299,9 @@ static int cam_vfe_bus_start_wm(
		return -EINVAL;
		}
		}

		/* Enable WM */
		cam_io_w_mb(rsrc_data->en_cfg, common_data->mem_base +
		rsrc_data->hw_regs->cfg);
		/* enabling Wm configuratons are taken care in update_wm().
		* i.e enable wm only if io buffers are allocated
		*/

		CAM_DBG(CAM_ISP, "WM res %d width = %d, height = %d", rsrc_data->index,
		rsrc_data->width, rsrc_data->height);