Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bdd1d278 authored by Alexander Aring's avatar Alexander Aring Committed by Greg Kroah-Hartman
Browse files

net: ieee802154: fix nl802154 add llsec key 



commit 20d5fe2d7103f5c43ad11a3d6d259e9d61165c35 upstream.

This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_KEY is
not set by the user. If this is the case nl802154 will return -EINVAL.

Reported-by: default avatar <syzbot+ce4e062c2d51977ddc50@syzkaller.appspotmail.com>
Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20210221174321.14210-3-aahringo@redhat.com


Signed-off-by: default avatarStefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3fe0c048

net/ieee802154/nl802154.c

+2 −1
Original line number Diff line number Diff line
@@ -1562,7 +1562,8 @@ static int nl802154_add_llsec_key(struct sk_buff *skb, struct genl_info *info) 
	struct ieee802154_llsec_key_id id = { };

	u32 commands[NL802154_CMD_FRAME_NR_IDS / 32] = { };



	if (nla_parse_nested(attrs, NL802154_KEY_ATTR_MAX,

	if (!info->attrs[NL802154_ATTR_SEC_KEY] ||

	    nla_parse_nested(attrs, NL802154_KEY_ATTR_MAX,

			     info->attrs[NL802154_ATTR_SEC_KEY],

			     nl802154_key_policy, info->extack))

		return -EINVAL;