Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3fe0c048 authored by Alexander Aring's avatar Alexander Aring Committed by Greg Kroah-Hartman
Browse files

net: ieee802154: fix nl802154 del llsec dev 



commit 3d1eac2f45585690d942cf47fd7fbd04093ebd1b upstream.

This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVICE is
not set by the user. If this is the case nl802154 will return -EINVAL.

Reported-by: default avatar <syzbot+d946223c2e751d136c94@syzkaller.appspotmail.com>
Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20210221174321.14210-2-aahringo@redhat.com


Signed-off-by: default avatarStefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 79ba55c0

net/ieee802154/nl802154.c

+2 −1
Original line number Diff line number Diff line
@@ -1781,7 +1781,8 @@ static int nl802154_del_llsec_dev(struct sk_buff *skb, struct genl_info *info) 
	struct nlattr *attrs[NL802154_DEV_ATTR_MAX + 1];

	__le64 extended_addr;



	if (nla_parse_nested(attrs, NL802154_DEV_ATTR_MAX,

	if (!info->attrs[NL802154_ATTR_SEC_DEVICE] ||

	    nla_parse_nested(attrs, NL802154_DEV_ATTR_MAX,

			     info->attrs[NL802154_ATTR_SEC_DEVICE],

			     nl802154_dev_policy, info->extack))

		return -EINVAL;