Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b8d5d5ff authored by Vasanthakumar Thiagarajan's avatar Vasanthakumar Thiagarajan Committed by Kalle Valo
Browse files

ath6kl: Fix htc_packet leak in ath6kl_htc_rx_fetch() 



It is found during the code review. As the leak would happen only
in failure case, the imapct is not easily visible.

Signed-off-by: default avatarVasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 4159cc93

drivers/net/wireless/ath/ath6kl/htc.c

+2 −4
Original line number Diff line number Diff line
@@ -1715,12 +1715,10 @@ static int ath6kl_htc_rx_fetch(struct htc_target *target, 
			packet = list_first_entry(rx_pktq, struct htc_packet,

						   list);



			list_del(&packet->list);



			/* fully synchronous */

			packet->completion = NULL;



			if (!list_empty(rx_pktq))

			if (!list_is_singular(rx_pktq))

				/*

				 * look_aheads in all packet

				 * except the last one in the
@@ -1735,7 +1733,7 @@ static int ath6kl_htc_rx_fetch(struct htc_target *target, 
			if (status)

				return status;



			list_add_tail(&packet->list, comp_pktq);

			list_move_tail(&packet->list, comp_pktq);

		}

	}