Commit 4159cc93 authored Oct 03, 2011 by Vasanthakumar Thiagarajan Committed by Kalle Valo Nov 11, 2011

ath6kl: Fix htc_packet leak in ath6kl_htc_rx_process_packets()



Packet is not reclaimed when ath6kl_htc_rx_process_hdr() fails.
Fix this by deferring the packet deletion from comp_pktq till
ath6kl_htc_rx_process_hdr() returns success. This bug is found
in code review, impact is not easily visible as the leak happens
only in failure cases.

Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

parent 861dd058

drivers/net/wireless/ath/ath6kl/htc.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1643,7 +1643,6 @@ static int ath6kl_htc_rx_process_packets(struct htc_target *target,
		int status = 0;

		list_for_each_entry_safe(packet, tmp_pkt, comp_pktq, list) {
		list_del(&packet->list);
		ep = &target->endpoint[packet->endpoint];

		/* process header for each of the recv packet */
		@@ -1652,6 +1651,8 @@ static int ath6kl_htc_rx_process_packets(struct htc_target *target,
		if (status)
		return status;

		list_del(&packet->list);

		if (list_empty(comp_pktq)) {
		/*
		* Last packet's more packet flag is set